Github user cenyuhai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1142#discussion_r126298624
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java
---
@@ -88,17 +90,12 @@ private void initialize(InputSplit inputSplit,
Configuration conf) throws IOExce
} catch (QueryExecutionException e) {
throw new IOException(e.getMessage(), e.getCause());
}
- if (valueObj == null) {
- valueObj =
- new ArrayWritable(Writable.class, new
Writable[queryModel.getProjectionColumns().length]);
- }
-
final TypeInfo rowTypeInfo;
final List<String> columnNames;
List<TypeInfo> columnTypes;
// Get column names and sort order
final String colIds = conf.get("hive.io.file.readcolumn.ids");
- final String columnNameProperty =
conf.get("hive.io.file.readcolumn.names");
+ final String columnNameProperty =
conf.get(serdeConstants.LIST_COLUMNS);
--- End diff --
why change to serdeConstants.LIST_COLUMNSï¼ I had got columnNameProperty
from serdeConstants.LIST_COLUMNS, but I found that the columns in
serdeConstants.LIST_COLUMNS sometimes contains columns which don't belong to
this table
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
