Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1237#discussion_r131462552
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -106,23 +106,13 @@ public CarbonFactDataWriterImplV3(CarbonDataWriterVo
dataWriterVo) {
throws CarbonDataWriterException {
// condition for writting all the pages
if (!encodedTablePage.isLastPage()) {
- boolean isAdded = false;
// check if size more than blocklet size then write the page to file
if (dataWriterHolder.getSize() + encodedTablePage.getEncodedSize()
>= blockletSize) {
- // if one page size is more than blocklet size
- if (dataWriterHolder.getEncodedTablePages().size() == 0) {
- isAdded = true;
- dataWriterHolder.addPage(encodedTablePage);
- }
-
LOGGER.info("Number of Pages for blocklet is: " +
dataWriterHolder.getNumberOfPagesAdded()
+ " :Rows Added: " + dataWriterHolder.getTotalRows());
// write the data
writeBlockletToFile();
}
- if (!isAdded) {
- dataWriterHolder.addPage(encodedTablePage);
--- End diff --
For both cases (isAdded true or false), it will invoke
`dataWriterHolder.addPage(encodedTablePage);`, so removing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
