Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1257#discussion_r134694501
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordSet.java
 ---
    @@ -79,30 +81,27 @@ private Expression 
parseConstraint2Expression(TupleDomain<ColumnHandle> constrai
       @Override public RecordCursor cursor() {
         List<TableBlockInfo> tableBlockInfoList = new 
ArrayList<TableBlockInfo>();
     
    -    tableBlockInfoList.add(new 
TableBlockInfo(split.getLocalInputSplit().getPath().toString(),
    +    tableBlockInfoList.add(new 
TableBlockInfo(split.getLocalInputSplit().getPath(),
             split.getLocalInputSplit().getStart(), 
split.getLocalInputSplit().getSegmentId(),
             split.getLocalInputSplit().getLocations().toArray(new String[0]),
             split.getLocalInputSplit().getLength(), new BlockletInfos(),
             //blockletInfos,
             
ColumnarFormatVersion.valueOf(split.getLocalInputSplit().getVersion()), null));
    -    queryModel.setTableBlockInfos(tableBlockInfoList);
     
    +    queryModel.setTableBlockInfos(tableBlockInfoList);
         queryExecutor = QueryExecutorFactory.getQueryExecutor(queryModel);
     
    -    try {
    +    CarbonProperties.getInstance().addProperty("carbon.detail.batch.size",
    --- End diff --
    
    I can't find where code use this property(carbon.detail.batch.size)? don't 
know need to add property at here ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to