[GitHub] carbondata pull request #1346: [CARBONDATA-1472] Optimize memory and fix nos...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1346#discussion_r138338482
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/unsafe/UnsafeAbstractDimensionDataChunkStore.java
 ---
    @@ -68,10 +72,9 @@
        * @param numberOfRows   total number of rows
        */
       public UnsafeAbstractDimensionDataChunkStore(long totalSize, boolean 
isInvertedIdex,
    -      int numberOfRows) {
    +      int numberOfRows) throws MemoryException {
         // allocating the data page
    -    this.dataPageMemoryBlock =
    -        
MemoryAllocatorFactory.INSATANCE.getMemoryAllocator().allocate(totalSize);
    +    this.dataPageMemoryBlock = 
UnsafeMemoryManager.allocateMemoryWithRetry(taskId, totalSize);
    --- End diff --
    
    ok


---