[GitHub] carbondata pull request #1321: [CARBONDATA-1438] Unify the sort column and s...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1321#discussion_r138830621
  
    --- Diff: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
 ---
    @@ -172,6 +173,13 @@ case class CreateTable(cm: TableModel) extends 
RunnableCommand {
     
         val tableInfo: TableInfo = TableNewProcessor(cm)
     
    +    // Add validation for sort scope when create table
    +    val sortScope = 
tableInfo.getFactTable.getTableProperties.get("sort_scope")
    +    if (null != sortScope && !CarbonUtil.isValidSortOption(sortScope)) {
    --- End diff --
    
    `null != sortScope` can be removed, it is checked inside 
`CarbonUtil.isValidSortOption`


---