Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r139123880
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapWriter.java ---
    @@ -32,7 +32,12 @@
       /**
        * End of block notification
        */
    -  void onBlockEnd(String blockId);
    +  void onBlockEnd(String blockId, String directoryPath);
    +
    +  /**
    +   * End of block notification when index got created.
    +   */
    +  void onBlockEndWithIndex(String blockId, String directoryPath);
    --- End diff --
    
    But during onBlockEnd as the carbonIndex is not yet written, we wont be 
able to access the carbonIndex files. In the example i am gathering 
informations from CarbonIndex Files too. 
    Better to keep hook after writing Index Files also. In future we may need 
some more hooks at different points.


---

Reply via email to