Github user dhatchayani commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1374#discussion_r140146423
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -617,7 +617,13 @@ abstract class CarbonDDLSqlParser extends
AbstractCarbonSparkSQLParser {
// by default consider all String cols as dims and if any dictionary
include isn't present then
// add it to noDictionaryDims list. consider all dictionary
excludes/include cols as dims
fields.foreach { field =>
- if (dictIncludeCols.exists(x => x.equalsIgnoreCase(field.column))) {
+ if (dictExcludeCols.exists(x => x.equalsIgnoreCase(field.column))) {
+ val dataType =
DataTypeUtil.getDataType(field.dataType.get.toUpperCase())
+ if (dataType != DataType.DATE) {
--- End diff --
we are already having a whitelist for dictionary_exclude that will filter
out date. so this check can be removed
---
