Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1439#discussion_r147604429
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataLoadingUtil.scala
 ---
    @@ -0,0 +1,300 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.util
    +
    +import scala.collection.immutable
    +import scala.collection.JavaConverters._
    +import scala.collection.mutable
    +
    +import org.apache.commons.lang3.StringUtils
    +
    +import org.apache.carbondata.common.constants.LoggerAction
    +import org.apache.carbondata.common.logging.LogServiceFactory
    +import org.apache.carbondata.core.constants.{CarbonCommonConstants, 
CarbonLoadOptionConstants}
    +import org.apache.carbondata.core.metadata.schema.table.CarbonTable
    +import org.apache.carbondata.core.util.{CarbonProperties, CarbonUtil}
    +import 
org.apache.carbondata.processing.loading.constants.DataLoadProcessorConstants
    +import 
org.apache.carbondata.processing.loading.model.{CarbonDataLoadSchema, 
CarbonLoadModel}
    +import org.apache.carbondata.processing.util.TableOptionConstant
    +import 
org.apache.carbondata.spark.exception.MalformedCarbonCommandException
    +import org.apache.carbondata.spark.load.ValidateUtil
    +
    +/**
    + * the util object of data loading
    + */
    +object DataLoadingUtil {
    --- End diff --
    
    I think these classes are still the part of Integration. They bridge the 
difference between spark module and the processing module.


---

Reply via email to