[GitHub] carbondata pull request #1464: [WIP][CARBONDATA-1523]Pre Aggregate table sel...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1464#discussion_r148995547
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapSchema.java
 ---
    @@ -116,6 +218,83 @@ public void setProperties(Map<String, String> 
properties) {
           String value = in.readUTF();
           this.properties.put(key, value);
         }
    +  }
     
    +  /**
    +   * Below method will be used to get the columns on which aggregate 
function is not applied
    +   * @param columnName
    +   *                parent column name
    +   * @return child column schema
    +   */
    +  public ColumnSchema getChildColBasedByParentForNonAggF(String 
columnName) {
    --- End diff --
    
    Better name as `getNonAggChildColumnByParentColName`


---