Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1471#discussion_r151828034
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/dev/BlockletSerializer.java
 ---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.datamap.dev;
    +
    +import java.io.DataInputStream;
    +import java.io.DataOutputStream;
    +import java.io.IOException;
    +
    +import org.apache.carbondata.core.datastore.impl.FileFactory;
    +import org.apache.carbondata.core.indexstore.FineGrainBlocklet;
    +
    +public class BlockletSerializer {
    +
    +  /**
    +   * Serialize and write blocklet to the file.
    +   * @param grainBlocklet
    +   * @param writePath
    +   * @throws IOException
    +   */
    +  public void serializeBlocklet(FineGrainBlocklet grainBlocklet, String 
writePath)
    --- End diff --
    
    Can we move this to FineGrainBlocklet itself? So that we do not need to 
keep writePath in many places, like in TableBlockInfo


---

Reply via email to