Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1524#discussion_r151831621
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithDiffTimestampFormat.scala
 ---
    @@ -75,55 +76,19 @@ class TestLoadDataWithDiffTimestampFormat extends 
QueryTest with BeforeAndAfterA
           assert(false)
         } catch {
           case ex: MalformedCarbonCommandException =>
    -        assertResult(ex.getMessage)("Error: Option DateFormat is not 
provided for Column date.")
    +        assertResult(ex.getMessage)("Error: Wrong option: date is provided 
for option DateFormat")
           case _: Throwable=> assert(false)
         }
     
         try {
           sql(s"""
                LOAD DATA LOCAL INPATH 
'$resourcesPath/timeStampFormatData1.csv' into table t3
    -           OPTIONS('dateformat' = 'fasfdas:yyyy/MM/dd')
    --- End diff --
    
    why delete these testcase? `dateformat` is still a valid loading option, 
right?


---

Reply via email to