GitHub user xuchuanyin opened a pull request: https://github.com/apache/carbondata/pull/1594
[CARBONDATA-1838] Refactor SortStepRowUtil to make it more readable Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [X] Any interfaces changed? `YES. REFACTORED convertRow INTERFACE IN SortStepRowUtil` - [X] Any backward compatibility impacted? `NO` - [X] Document update required? `NO` - [X] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? `NO, ONLY REFACTOR THE CODE, DIDN'T CHANGE THE FUNCTION` - How it is tested? Please attach test report. `TESTED IN LOCAL CLUSTER WITH 3 NODES, DATA LOADING AND QUERYING IS OK` - Is it a performance related change? Please attach the performance test report. `NO` - Any additional information to help reviewers in testing this change. `NO` - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. `NOT RELATED` NOTE === Refactor and optimize `SortRowStepUtil` to make it efficient and more readable. 1. Firstly we get all the indices for the 3 groups: dictionary columns, non dictionary dimension columns and measures; 2. Then for each group, just iterate the source row and copy data to each group without any if-else branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuchuanyin/carbondata opt_sort_step_row_util Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1594 ---- commit 9eb8f88da71c5c0e9196ace9cd1fd150987f14af Author: xuchuanyin <xuchuan...@hust.edu.cn> Date: 2017-11-29T12:40:44Z refactor sort step row ---- ---