Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1565#discussion_r154094455
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
 ---
    @@ -197,6 +197,7 @@
           thriftColumnSchema.setColumnProperties(properties);
         }
         
thriftColumnSchema.setAggregate_function(wrapperColumnSchema.getAggFunction());
    +    
thriftColumnSchema.setTimeSeriesFunction(wrapperColumnSchema.getTimeSeriesFunction());
    --- End diff --
    
    I don't think we should add a new field to schema about this, let it be as 
tableProperty only.


---

Reply via email to