[GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1605#discussion_r154975193
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
 ---
    @@ -493,4 +493,20 @@ object PreAggregateUtil {
         updatedPlan
       }
     
    +  def createChildSelectQuery(tableSchema: TableSchema): String = {
    --- End diff --
    
    Instead of creating a SQL string, you can construct a dataframe directly 
and return to startCompactionForDataMap


---