Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1656#discussion_r156841880
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/CastExpressionOptimization.scala
 ---
    @@ -82,6 +109,21 @@ object CastExpressionOptimization {
         }
       }
     
    +  def typeCastStringToLongListForDateType(list: Seq[Expression]): 
Seq[Expression] = {
    --- End diff --
    
    code duplicated, extract common code


---

Reply via email to