Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1642#discussion_r157133238 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -18,22 +18,311 @@ package org.apache.carbondata.hadoop.api; import java.io.IOException; +import java.util.List; +import java.util.Random; -import org.apache.hadoop.fs.FileSystem; -import org.apache.hadoop.mapred.FileOutputFormat; -import org.apache.hadoop.mapred.JobConf; -import org.apache.hadoop.mapred.RecordWriter; -import org.apache.hadoop.util.Progressable; +import org.apache.carbondata.common.CarbonIterator; +import org.apache.carbondata.core.constants.CarbonCommonConstants; +import org.apache.carbondata.core.constants.CarbonLoadOptionConstants; +import org.apache.carbondata.core.metadata.datatype.StructField; +import org.apache.carbondata.core.metadata.datatype.StructType; +import org.apache.carbondata.core.metadata.schema.table.CarbonTable; +import org.apache.carbondata.core.metadata.schema.table.TableInfo; +import org.apache.carbondata.core.util.CarbonProperties; +import org.apache.carbondata.hadoop.util.ObjectSerializationUtil; +import org.apache.carbondata.processing.loading.DataLoadExecutor; +import org.apache.carbondata.processing.loading.csvinput.StringArrayWritable; +import org.apache.carbondata.processing.loading.iterator.CarbonOutputIteratorWrapper; +import org.apache.carbondata.processing.loading.model.CarbonDataLoadSchema; +import org.apache.carbondata.processing.loading.model.CarbonLoadModel; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.io.NullWritable; +import org.apache.hadoop.mapreduce.OutputCommitter; +import org.apache.hadoop.mapreduce.RecordWriter; +import org.apache.hadoop.mapreduce.TaskAttemptContext; +import org.apache.hadoop.mapreduce.lib.output.FileOutputFormat; /** * Base class for all output format for CarbonData file. - * @param <T> */ -public abstract class CarbonTableOutputFormat<T> extends FileOutputFormat<Void, T> { +public class CarbonTableOutputFormat extends FileOutputFormat<NullWritable, StringArrayWritable> { + + private static final String LOAD_MODEL = "mapreduce.carbonoutputformat.load.mmodel"; + private static final String DATABASE_NAME = "mapreduce.carbonoutputformat.databaseName"; + private static final String TABLE_NAME = "mapreduce.carbonoutputformat.tableName"; + private static final String TABLE = "mapreduce.carbonoutputformat.table"; + private static final String TABLE_PATH = "mapreduce.carbonoutputformat.tablepath"; + private static final String INPUT_SCHEMA = "mapreduce.carbonoutputformat.inputschema"; + private static final String TEMP_STORE_LOCATIONS = "carbon.load.tempstore.locations"; + private static final String OVERWRITE_SET = "carbon.load.set.overwrite"; --- End diff -- Why this name start with carbon, it should start with mapreduce, right?
---