Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1665#discussion_r157405351
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetaStore.scala
 ---
    @@ -144,6 +145,15 @@ trait CarbonMetaStore {
       def getThriftTableInfo(tablePath: CarbonTablePath)(sparkSession: 
SparkSession): TableInfo
     
       def getTableFromMetadataCache(database: String, tableName: String): 
Option[CarbonTable]
    +
    +  def getCarbonDataSourceHadoopRelation(sparkSession: SparkSession,
    +      tableIdentifier: TableIdentifier): CarbonDatasourceHadoopRelation
    +
    +  def getSchemaFromUnresolvedRelation(sparkSession: SparkSession,
    --- End diff --
    
    This method is called from the parser and this logic for retrieving schema 
from unresolved relation, according to me should not return in parser. Please 
let me know if you have a different perspective


---

Reply via email to