Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1675#discussion_r157953727
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
 ---
    @@ -57,8 +62,10 @@
     
       public RowResultMergerProcessor(String databaseName,
           String tableName, SegmentProperties segProp, String[] 
tempStoreLocation,
    -      CarbonLoadModel loadModel, CompactionType compactionType) {
    +      CarbonLoadModel loadModel, CompactionType compactionType, 
List<String> partitionNames) {
         this.segprop = segProp;
    +    this.partitionNames = partitionNames;
    +    this.loadModel = loadModel;
    --- End diff --
    
    How about keeping the segment path in this class and use it in line 162 
instead of keeping the whole load model in this class?


---

Reply via email to