Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1694#discussion_r158934001
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
 ---
    @@ -508,7 +583,10 @@ object PreAggregateUtil {
         val headers = 
dataMapSchemas.find(_.getChildSchema.getTableName.equalsIgnoreCase(
           dataMapIdentifier.table)) match {
           case Some(dataMapSchema) =>
    -        
dataMapSchema.getChildSchema.getListOfColumns.asScala.sortBy(_.getSchemaOrdinal).map(
    +        val columns = dataMapSchema.getChildSchema.getListOfColumns.asScala
    +          .filter{f =>
    --- End diff --
    
    change `f` to a meaningful variable, add space before `{`


---

Reply via email to