Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1734#discussion_r158956093 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala --- @@ -156,15 +156,20 @@ private[sql] case class CarbonAlterTableRenameCommand( } catch { case e: Exception => LOGGER.error(e, "Rename table failed: " + e.getMessage) - if (carbonTable != null) { - AlterTableUtil - .revertRenameTableChanges(oldTableIdentifier, - newTableName, - carbonTable.getTablePath, - carbonTable.getCarbonTableIdentifier.getTableId, - timeStamp)( - sparkSession) - renameBadRecords(newTableName, oldTableName, oldDatabaseName) + try { + if (carbonTable != null) { + AlterTableUtil + .revertRenameTableChanges(oldTableIdentifier, + newTableName, + carbonTable.getTablePath, + carbonTable.getCarbonTableIdentifier.getTableId, + timeStamp)( + sparkSession) + renameBadRecords(newTableName, oldTableName, oldDatabaseName) + } + } catch { + case e: Exception => --- End diff -- use finally, without catch
---