Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1729#discussion_r159369856
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
 ---
    @@ -156,54 +158,156 @@ object CarbonScalaUtil {
       }
     
       /**
    -   * Converts incoming value to UTF8String after converting data as per 
the data type.
    +   * Converts incoming value to String after converting data as per the 
data type.
        * @param value Input value to convert
    -   * @param dataType Datatype to convert and then convert to UTF8String
    +   * @param dataType Datatype to convert and then convert to String
        * @param timeStampFormat Timestamp format to convert in case of 
timestamp datatypes
    -   * @param dateFormat DataFormat to convert incase of DateType datatype
    +   * @param dateFormat DataFormat to convert in case of DateType datatype
        * @param serializationNullFormat if this encounters in input data then 
data will
        *                                be treated as null
    -   * @param fail If it is true then any conversion error will trhow error 
otherwise it will be
    -   *                   filled with ull value
    -   * @return converted UTF8String
    +   * @return converted String
        */
    -  def convertToUTF8String(value: String,
    +  def convertToString(value: String,
    --- End diff --
    
    move parameter to next line


---

Reply via email to