Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1811#discussion_r162040412
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java
---
@@ -294,20 +292,19 @@ private static void
addChildrenBlockIndex(Set<Integer> blockIndexes, CarbonDimen
// write encoding dictionary
if (CarbonUtil.hasEncoding(encodingList, Encoding.DICTIONARY) &&
!CarbonUtil
.hasEncoding(encodingList, Encoding.DIRECT_DICTIONARY) &&
!CarbonUtil
- .hasEncoding(encodingList, Encoding.IMPLICIT)) {
-
- if (queryDimensions.get(i).getDimension().getNumberOfChild() == 0)
{
-
dictionaryDimensionFromQuery.add(queryDimensions.get(i).getDimension().getColumnId());
- }
- if (queryDimensions.get(i).getDimension().getNumberOfChild() > 0) {
-
getChildDimensionDictionaryDetail(queryDimensions.get(i).getDimension(),
- dictionaryDimensionFromQuery);
- }
+ .hasEncoding(encodingList, Encoding.IMPLICIT)
+ && queryDimensions.get(i).getDimension().getNumberOfChild() > 0)
{
--- End diff --
Better use isComplex()
---