Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1781#discussion_r163765606
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
 ---
    @@ -900,4 +904,75 @@ object PreAggregateUtil {
             aggDataMapSchema.getProperties.get("CHILD_SELECT 
QUERY").replace("&", "=")),
           CarbonCommonConstants.DEFAULT_CHARSET)
       }
    +
    +  def commitDataMaps(
    +      carbonLoadModel: CarbonLoadModel,
    +      uuid: String = "")(sparkSession: SparkSession) {
    --- End diff --
    
    take this a Option and default to None


---

Reply via email to