Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1861#discussion_r165271343
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateLoad.scala
 ---
    @@ -310,5 +310,99 @@ test("check load and select for avg double datatype") {
         checkAnswer(sql("select name,avg(salary) from maintbl group by name"), 
rows)
       }
     
    +  test("create datamap with 'if not exists' after load data into mainTable 
and create datamap") {
    --- End diff --
    
    I think no need to add test cases in all the files. One test case in 
TestPreAggregateCreateCommand and one in TestTimeseriesCreateTable would be 
enough.


---

Reply via email to