Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1919#discussion_r165809791
  
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -192,13 +192,13 @@ struct DataMapSchema  {
         1: required string dataMapName;
         // class name
         2: required string className;
    -    // relation indentifier
    -    3: optional RelationIdentifier relationIdentifire;
    -    // in case of preaggregate it will be used to maintain the child schema
    -    // which will be usefull in case of query and data load
    -    4: optional TableSchema childTableSchema;
         // to maintain properties like select query, query type like groupby, 
join
    -    5: optional map<string, string> properties;
    +    3: optional map<string, string> properties;
    +    // relation indentifier of a table which stores data of datamaps like 
preaggregate/timeseries.
    --- End diff --
    
    typo, identifier


---

Reply via email to