Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1812
  
    @gvramana 
    I think ‘major’ and ‘minor’ is enough to describe compaction, there 
is no need to add another on. And 'custom' is somewhat ambiguous.
    
    As it is described in readme,
    ```
    In Major compaction, multiple segments can be merged into one large 
segment. User will specify the compaction size until which segments can be 
merged.
    ```
    The previous (default without condition) major compaction is size based, 
carbondata choose the segments by size. And for the newly major compaction 
(with condition), we specify the segments and let carbondata merge them into 
one large segment. They are no different. So we don't need an another 
compaction type.


---

Reply via email to