Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1856#discussion_r174127189
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesDropSuite.scala
 ---
    @@ -16,15 +16,28 @@
      */
     package org.apache.carbondata.integration.spark.testsuite.timeseries
     
    +import org.apache.spark.sql.AnalysisException
     import org.apache.spark.sql.test.util.QueryTest
     import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
     
    -import 
org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException
    +import 
org.apache.carbondata.common.exceptions.sql.{MalformedCarbonCommandException, 
NoSuchDataMapException}
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.carbondata.spark.exception.ProcessMetaDataException
     
     class TestTimeSeriesDropSuite extends QueryTest with BeforeAndAfterAll 
with BeforeAndAfterEach {
     
    +  val timeSeries = "timeseries"
    +  var timestampFormat: String = _
    --- End diff --
    
    @sraghunandan suggested should not change the CarbonCommonConstants values 
after running the test case, because other place maybe need this constants 
value.


---

Reply via email to