Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2097#discussion_r176899943
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/writer/CarbonDeleteDeltaWriterImpl.java
 ---
    @@ -81,7 +80,9 @@ public CarbonDeleteDeltaWriterImpl(String filePath, 
FileFactory.FileType fileTyp
           if (null != dataOutStream) {
             dataOutStream.flush();
           }
    -      CarbonUtil.closeStreams(brWriter, dataOutStream);
    +      if (null != brWriter) {
    +        brWriter.close();
    +      }
    --- End diff --
    
    there is a catch block above in this method for IOException.....there we 
are only logging the exception...kindly add a throw statement in that catch 
block also after logging the error


---

Reply via email to