Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2083#discussion_r177979593
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
 ---
    @@ -493,6 +629,210 @@ case class CarbonPreAggregateQueryRules(sparkSession: 
SparkSession) extends Rule
         updatedPlan
       }
     
    +  /**
    +   * Method to get the aggregate query plan
    +   * @param aggPlan
    +   * aggregate table query plan
    +   * @param grExp
    +   * fact group by expression
    +   * @param aggExp
    +   * fact aggregate expression
    +   * @param carbonTable
    +   * fact table
    +   * @param aggregationDataMapSchema
    +   * selected aggregation data map
    +   * @param factAggPlan
    +   * fact aggregate query plan
    +   * @return updated plan
    +   */
    +  def getAggregateQueryPlan(aggPlan: LogicalPlan,
    +      grExp: Seq[Expression],
    +      aggExp: Seq[NamedExpression],
    +      carbonTable: CarbonTable,
    +      aggregationDataMapSchema: DataMapSchema,
    +      factAggPlan: LogicalPlan): LogicalPlan = {
    +    // to handle streaming table with pre aggregate
    +    if (carbonTable.isStreamingTable) {
    +      setSegmentsForStreaming(carbonTable, aggregationDataMapSchema)
    --- End diff --
    
    fixed


---

Reply via email to