GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2122
[CARBONDATA-2296] Fix create datamap command with out on table syntax and
correct the target location of test framework
Problem
1 Create datamap command fails if user does not mention `on table`
2 Test framework try to create metastore and store location in
integration/spark-common location but if it runs from other modules like
datamap it creates target location in wrong place.
Solution
Check the null for parent table if not present and always take the present
module target location as store path location if it not under integration
module.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata
testframeworkupdate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2122
----
commit a6c19b83d21133788b2371ff37f03b86e0eb76dc
Author: ravipesala <ravi.pesala@...>
Date: 2018-03-31T02:42:44Z
Fix create datamap command with out on table syntax and correct the target
location of test framework
----
---
