Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r179340305
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapFactory.java
---
@@ -62,6 +63,12 @@
*/
void fireEvent(Event event);
+ /**
+ * Add the dataMap to cache
+ * @param dataMap
+ */
+ void addDataMapToCache(DataMap dataMap) throws IOException,
MemoryException;
--- End diff --
Better add these methods in another interface CacheableDataMap and
implement it to BlockletDataMapFactory directly.
```
CacheableDataMap {
void cache(List<DataMap> dataMaps)
List<DataMapDistributable> getAllUncachedDataMaps()
}
```
---
