GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2206

    [WIP] Improve Lucene datamap performance by eliminating blockid while 
writing and reading index.

    This PR is depends on PR https://github.com/apache/carbondata/pull/2204
    Problem:
    Currently DataMap interface implementations use blockid and blockletid 
while writing index files, Actually blockid is not needed to store in index 
files as it only requires blockletid.  So it adds more memory and disk size to 
write index files.
    
    Solution:
    Use taskname as index name to identify the indexname. And filter the 
blocklets directly by avoiding blockids.And pass the taskName as indexname to 
identify the blockid from blocletdatamap.
    
    Corrected the implementations of  LuceneDatamap, CGDataMap, FGDataMap and 
MinMaxDataMap
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance 
test report.
            - Any additional information to help reviewers in testing this 
change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata 
improved-lucene

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2206
    
----
commit 219c217950737f42fd6e98f48f1a6968c0721774
Author: ravipesala <ravi.pesala@...>
Date:   2018-04-21T16:29:50Z

    Added CG prune before FG prune.

commit 22c154791949676dc55a1ef1d704e05ec88552d8
Author: ravipesala <ravi.pesala@...>
Date:   2018-04-22T04:49:53Z

    Improved Lucene datamap by compacting index size by eliminating blockId

----


---

Reply via email to