Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2244#discussion_r184915943
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/CacheClient.java ---
    @@ -16,21 +16,40 @@
      */
     package org.apache.carbondata.hadoop;
     
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.ConcurrentHashMap;
    +
    +import org.apache.carbondata.common.logging.LogService;
    +import org.apache.carbondata.common.logging.LogServiceFactory;
     import org.apache.carbondata.core.cache.Cache;
     import org.apache.carbondata.core.cache.CacheProvider;
     import org.apache.carbondata.core.cache.CacheType;
    +import org.apache.carbondata.core.datastore.SegmentTaskIndexStore;
     import org.apache.carbondata.core.datastore.TableSegmentUniqueIdentifier;
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
     import org.apache.carbondata.core.datastore.block.SegmentTaskIndexWrapper;
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
    +import 
org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema;
     
     /**
      * CacheClient : Holds all the Cache access clients for Btree, Dictionary
      */
     public class CacheClient {
     
    +  private static final LogService LOGGER =
    +      LogServiceFactory.getLogService(CacheClient.class.getName());
    +
    +  private final Object lock = new Object();
    +
       // segment access client for driver LRU cache
       private CacheAccessClient<TableSegmentUniqueIdentifier, 
SegmentTaskIndexWrapper>
           segmentAccessClient;
     
    +  private static Map<SegmentTaskIndexStore.SegmentPropertiesWrapper, 
SegmentProperties>
    +      segmentProperties =
    +      new ConcurrentHashMap<>();
    --- End diff --
    
    Move this to above line


---

Reply via email to