Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2261#discussion_r186055820
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
    @@ -367,9 +384,8 @@ private CarbonTable buildCarbonTable() {
           //  user passed size 4 but supplied only 2 fileds
           for (Field field : schema.getFields()) {
             if (null != field) {
    -          if (field.getDataType() == DataTypes.STRING ||
    -              field.getDataType() == DataTypes.DATE ||
    -              field.getDataType() == DataTypes.TIMESTAMP) {
    +          if (field.getDataType() == DataTypes.STRING || 
field.getDataType() == DataTypes.DATE
    --- End diff --
    
    This check is for creating all the dimension columns as sort columns when 
by default sort column is not specified. 


---

Reply via email to