Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2255#discussion_r186294696
  
    --- Diff: 
integration/spark2/src/test/scala/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapSuite.scala
 ---
    @@ -41,25 +42,34 @@ class BloomCoarseGrainDataMapSuite extends QueryTest 
with BeforeAndAfterAll {
         sql(s"DROP TABLE IF EXISTS $bloomDMSampleTable")
       }
     
    -  private def checkQuery = {
    +  override def afterEach(): Unit = {
    +    sql(s"DROP TABLE IF EXISTS $normalTable")
    +    sql(s"DROP TABLE IF EXISTS $bloomDMSampleTable")
    +  }
    +
    +  private def dmSql(sqlText: String, dataMapName: String, shouldHit: 
Boolean): DataFrame = {
    --- End diff --
    
    better to optimize the method name


---

Reply via email to