Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2279#discussion_r186723961
  
    --- Diff: 
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
 ---
    @@ -65,9 +65,18 @@
        * and all the indexed value is distinct.
        */
       private static final int DEFAULT_BLOOM_FILTER_SIZE = 32000 * 20;
    +  /**
    +   * property for fpp(false-positive-probability) of bloom filter
    +   */
    +  private static final String BLOOM_FPP = "bloom_fpp";
    --- End diff --
    
    Can you add a testcase for it


---

Reply via email to