Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2274#discussion_r189575742
  
    --- Diff: docs/sdk-writer-guide.md ---
    @@ -13,25 +13,33 @@ These SDK writer output contains just a carbondata and 
carbonindex files. No met
      
      import 
org.apache.carbondata.common.exceptions.sql.InvalidLoadOptionException;
      import org.apache.carbondata.core.metadata.datatype.DataTypes;
    + import org.apache.carbondata.core.util.CarbonProperties;
      import org.apache.carbondata.sdk.file.CarbonWriter;
      import org.apache.carbondata.sdk.file.CarbonWriterBuilder;
      import org.apache.carbondata.sdk.file.Field;
      import org.apache.carbondata.sdk.file.Schema;
      
      public class TestSdk {
    - 
    +
    + // pass true or false whle executing the main to use offheap memory or not
        public static void main(String[] args) throws IOException, 
InvalidLoadOptionException {
    -     testSdkWriter();
    +     if(args[0] != null) {
    +     testSdkWriter(args[0]);
    --- End diff --
    
    that is already handled in CarbonProperties validation.


---

Reply via email to