Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2334#discussion_r190103900
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java
 ---
    @@ -17,51 +17,28 @@
     
     package org.apache.carbondata.presto;
     
    -import java.math.BigDecimal;
    -import java.math.BigInteger;
    -import java.sql.Timestamp;
    -import java.util.ArrayList;
    -import java.util.Calendar;
    -import java.util.Date;
    -import java.util.HashMap;
    -import java.util.List;
    -import java.util.Map;
    -
    +import com.facebook.presto.spi.ColumnHandle;
    +import com.facebook.presto.spi.PrestoException;
    +import com.facebook.presto.spi.predicate.Domain;
    +import com.facebook.presto.spi.predicate.Range;
    +import com.facebook.presto.spi.predicate.TupleDomain;
    +import com.facebook.presto.spi.type.*;
    +import io.airlift.slice.Slice;
     import org.apache.carbondata.core.metadata.datatype.DataType;
     import org.apache.carbondata.core.metadata.datatype.DataTypes;
     import org.apache.carbondata.core.metadata.schema.table.CarbonTable;
     import 
org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema;
     import org.apache.carbondata.core.scan.expression.ColumnExpression;
     import org.apache.carbondata.core.scan.expression.Expression;
     import org.apache.carbondata.core.scan.expression.LiteralExpression;
    -import 
org.apache.carbondata.core.scan.expression.conditional.EqualToExpression;
    -import 
org.apache.carbondata.core.scan.expression.conditional.GreaterThanEqualToExpression;
    -import 
org.apache.carbondata.core.scan.expression.conditional.GreaterThanExpression;
    -import org.apache.carbondata.core.scan.expression.conditional.InExpression;
    -import 
org.apache.carbondata.core.scan.expression.conditional.LessThanEqualToExpression;
    -import 
org.apache.carbondata.core.scan.expression.conditional.LessThanExpression;
    -import 
org.apache.carbondata.core.scan.expression.conditional.ListExpression;
    +import org.apache.carbondata.core.scan.expression.conditional.*;
     import org.apache.carbondata.core.scan.expression.logical.AndExpression;
     import org.apache.carbondata.core.scan.expression.logical.OrExpression;
     
    -import com.facebook.presto.spi.ColumnHandle;
    -import com.facebook.presto.spi.PrestoException;
    -import com.facebook.presto.spi.predicate.Domain;
    -import com.facebook.presto.spi.predicate.Range;
    -import com.facebook.presto.spi.predicate.TupleDomain;
    -import com.facebook.presto.spi.type.BigintType;
    -import com.facebook.presto.spi.type.BooleanType;
    -import com.facebook.presto.spi.type.DateType;
    -import com.facebook.presto.spi.type.DecimalType;
    -import com.facebook.presto.spi.type.Decimals;
    -import com.facebook.presto.spi.type.DoubleType;
    -import com.facebook.presto.spi.type.IntegerType;
    -import com.facebook.presto.spi.type.SmallintType;
    -import com.facebook.presto.spi.type.TimestampType;
    -import com.facebook.presto.spi.type.Type;
    -import com.facebook.presto.spi.type.VarcharType;
    -import com.google.common.collect.ImmutableList;
    -import io.airlift.slice.Slice;
    +import java.math.BigDecimal;
    --- End diff --
    
    please optimize the order of class, unify with others


---

Reply via email to