Github user ndwangsen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2314#discussion_r190776632
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
 ---
    @@ -575,11 +577,12 @@ public static Dictionary 
getDictionary(AbsoluteTableIdentifier absoluteTableIden
        * @param noOfNodesInput -1 if number of nodes has to be decided
        *                       based on block location information
        * @param blockAssignmentStrategy strategy used to assign blocks
    +   * @param loadMinSize the property load_min_size_inmb specified by the 
user
        * @return a map that maps node to blocks
        */
       public static Map<String, List<Distributable>> nodeBlockMapping(
           List<Distributable> blockInfos, int noOfNodesInput, List<String> 
activeNodes,
    -      BlockAssignmentStrategy blockAssignmentStrategy) {
    +      BlockAssignmentStrategy blockAssignmentStrategy, String loadMinSize 
) {
    --- End diff --
    
    ok,I modify it according to your reviewed message,thanks.


---

Reply via email to