Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2290#discussion_r191300521
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommittedScope.java
 ---
    @@ -42,10 +39,27 @@
     public class LatestFilesReadCommittedScope implements ReadCommittedScope {
     
       private String carbonFilePath;
    +  private String segmentId;
       private ReadCommittedIndexFileSnapShot readCommittedIndexFileSnapShot;
       private LoadMetadataDetails[] loadMetadataDetails;
     
    -  public LatestFilesReadCommittedScope(String path)  {
    +  /**
    +   * a new constructor of this class, which supports obtain lucene index 
in search mode
    --- End diff --
    
    Better not to mention search mode. Describe what this constructor will do. 


---

Reply via email to