Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2335#discussion_r192945546
  
    --- Diff: 
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVState.scala 
---
    @@ -31,25 +31,25 @@ private[mv] class MVState(summaryDatasetCatalog: 
SummaryDatasetCatalog) {
       // Note: These are all lazy vals because they depend on each other (e.g. 
conf) and we
       // want subclasses to override some of the fields. Otherwise, we would 
get a lot of NPEs.
     
    -  /**
    -   * Modular query plan modularizer
    -   */
    -  lazy val modularizer = SimpleModularizer
    -
    -  /**
    -   * Logical query plan optimizer.
    -   */
    -  lazy val optimizer = BirdcageOptimizer
    -
    -  lazy val matcher = DefaultMatchMaker
    -
    -  lazy val navigator: Navigator = new Navigator(summaryDatasetCatalog, 
this)
    +//  /**
    +//   * Modular query plan modularizer
    +//   */
    +//  lazy val modularizer = SimpleModularizer
    +//
    +//  /**
    +//   * Logical query plan optimizer.
    +//   */
    --- End diff --
    
    Not required, removed


---

Reply via email to