Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2374#discussion_r195684966
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java
 ---
    @@ -291,6 +318,17 @@ public void write(DataOutput out) throws IOException {
           }
         }
         out.writeBoolean(isSchemaModified);
    +
    +    out.writeUTF(format);
    +    boolean isFormatPropertiesExists = null != formatProperties && 
formatProperties.size() > 0;
    +    out.writeBoolean(isFormatPropertiesExists);
    +    if (isFormatPropertiesExists) {
    +      out.writeShort(formatProperties.size());
    --- End diff --
    
    It is better to write `formateProperties` in one shot, performance is much 
better than writing each entry.


---

Reply via email to