Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2379#discussion_r196634573
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -64,7 +64,7 @@ public ColumnPageDecoder
createDecoder(ColumnPageEncoderMeta meta) {
return new DirectDecompressor(meta);
}
- private static class DirectCompressor extends ColumnPageEncoder {
--- End diff --
Yeah, it is required because in the method `getEncodingList`, we want to
use member `datatype` from the outside class. If it is static inner class, we
cannot access that member.
---
