GitHub user sv71294 opened a pull request:

    https://github.com/apache/carbondata/pull/2412

    [CARBONDATA-2656] Presto vector stream readers performance Enhancement 

    **Background**:
    In the present system, we create carbonColumnVectorImpl object in 
carbonVectorbatch where carbon core fill up vector data (one by one) in column 
matched data type array, later which at the time of presto block builder call, 
read by stream readers (based on data type) and iterated to fill up in block 
and returned to presto.
    
    **Solution**:
    We can eliminate the extra iteration over the carbonColumnVectorImpl object 
-> vectorArray, by extending it to StreamReaders which will fill up carbon-core 
vector data (one by one) directly to the block(presto), and on the call of 
block builder it will return the block to the Presto.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [x] Any interfaces changed?
     
     - [x] Any backward compatibility impacted? no
     
     - [x] Document update required? no
    
     - [x] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance 
test report.
            - Any additional information to help reviewers in testing this 
change.
           [Preformance test report](https://goo.gl/duTMBh)
     - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sv71294/carbondata carbon-presto-direct-reader

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2412
    
----
commit b5597f8d727ea75dba7935f1505cee97fd56123a
Author: sv71294 <sv71294@...>
Date:   2018-06-05T12:14:58Z

    direct vector readers

----


---

Reply via email to