[GitHub] carbondata pull request #2399: [CARBONDATA-2629] Support SDK carbon reader r...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2399#discussion_r199315517
  
    --- Diff: 
examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/SDKS3Example.java
 ---
    @@ -60,13 +63,19 @@ public static void main(String[] args) throws Exception 
{
             }
             writer.close();
             // Read data
    +
    +        EqualToExpression equalToExpression = new EqualToExpression(
    --- End diff --
    
    Yes, I am also worried about this exposure, I think it is better to create 
a simple DSL for user to pass the filter expression. For example: 
    ```
    c1 > 3
    c1 < 1 and c2 = 'apple'
    c1 in (3,4,5)
    c1 like ab*
    ```


---