[GitHub] carbondata pull request #2433: [CARBONDATA-2676]Support local Dictionary for...

[ajantha-bhat]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2433#discussion_r199370611
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
 ---
    @@ -76,6 +78,18 @@ public TableSchemaBuilder blockletSize(int blockletSize) 
{
         return this;
       }
     
    +  public TableSchemaBuilder localDictionaryThreshold(int 
localDictionaryThreshold) {
    +    this.localDictionaryThreshold = 
String.valueOf(localDictionaryThreshold);
    +    return this;
    +  }
    +
    +
    +  public TableSchemaBuilder isLocalDictionaryEnabled(boolean 
isLocalDictionaryEnabled) {
    +    this.isLocalDictionaryEnabled = isLocalDictionaryEnabled;
    --- End diff --
    
    please change the method name to "setLocalDictionaryEnabled"


---