Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2443#discussion_r200893470
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/carbondata/datamap/IndexDataMapRebuildRDD.scala
 ---
    @@ -144,13 +149,113 @@ class OriginalReadSupport(dataTypes: 
Array[DataType]) extends CarbonReadSupport[
       }
     }
     
    +/**
    + * This class will generate row value which is raw bytes for the 
dimensions.
    + */
    +class RawBytesReadSupport(segmentProperties: SegmentProperties, 
indexColumns: Array[CarbonColumn])
    --- End diff --
    
    Better move this to java class in carbon-hadoop module, so that all 
integration module can use it


---

Reply via email to