GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2486
[CARBONDATA-2723][DataMap] Fix bugs in recreate datamap on table
While we drop datamap/table, the executor side cache for datamap is
stale. So if we recreate the datamap with different index columns, when
we are doing data loading, the cache should be cleaned, otherwise the
DataMapWriterListener will not take effect for the new datamap.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata
CARBONDATA-2723_bug_recreate_dm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2486.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2486
----
commit a5a2b6f94cd42418106be2eba04d2d300a0f3891
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-07-11T04:23:18Z
Fix bugs in recreate datamap on table
While we drop datamap/table, the executor side cache for datamap is
stale. So if we recreate the datamap with different index columns, when
we are doing data loading, the cache should be cleaned, otherwise the
DataMapWriterListener will not take effect for the new datamap.
----
---
