Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2483#discussion_r202014007
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/UpdateCarbonTableTestCase.scala
 ---
    @@ -713,6 +713,44 @@ class UpdateCarbonTableTestCase extends QueryTest with 
BeforeAndAfterAll {
         sql("drop table if exists senten")
       }
     
    +  test("test to check if update table is reflected in table with 
datamaps") {
    --- End diff --
    
    please split it into two testcase, one for index datamap, another for 
preaggregate datamap
    
    the title can be "block updating table which has index datamap" and "block 
updating table which has preaggregate datamap"


---

Reply via email to