GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2511
[CARBONDATA-2745] Added atomic file operations for S3
Problem: AtomicFileOperationImpl creates a temporary file and then renames
the file to actual file name. This is risky in S3 storage as the file has to be
deleted and then recreated.
Solution: Create a seperate implementaion for s3 and while writing write
with the same name with overwrite mode.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata s3atomicfileoperations
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2511.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2511
----
commit 8e84566cc5bd4a572ec31ad4a017ac7128de6998
Author: kunal642 <kunalkapoor642@...>
Date: 2018-07-16T08:58:00Z
Added atomic file operations for S3
----
---
